plotly / plotly/plotly.R

Cannot have more than one shape after subplot()

未关闭
#1,869 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
R
星标
2.7k
派生
641
PR 合并指标
30 天内没有已合并 PR

描述

I guess this is related to #1333

Here is the issue: it doesn't seem possible to have more than one shape after subplot() is called. Applying the shapes to the individual plots work, though.

reprex that works:

library(plotly)

p1 <- plot_ly(mtcars, x = ~mpg, y = ~hp) %>% 
  layout(
    shapes = list(
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "dot"),
        x0 = 20, 
        x1 = 20,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      ),
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "solid"),
        x0 = 30, 
        x1 = 30,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      )
    )
  ) %>%
  config(editable = TRUE)

p2 <- plot_ly(mtcars, x = ~mpg, y = ~drat) %>% 
  layout(
    shapes = list(
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "dot"),
        x0 = 20, 
        x1 = 20,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      ),
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "solid"),
        x0 = 30, 
        x1 = 30,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      )
    )
  ) %>%
  config(editable = TRUE)

subplot(p1, p2, nrows = 2)

reprex that does not work:

library(plotly)

p1 <- plot_ly(mtcars, x = ~mpg, y = ~hp)

p2 <- plot_ly(mtcars, x = ~mpg, y = ~drat)

subplot(p1, p2, nrows = 2) %>% 
  layout(
    shapes = list(
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "dot"),
        x0 = 20, 
        x1 = 20,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      ),
      list(
        type = "line", 
        line = list(color = "#5681c4", dash = "solid"),
        x0 = 30, 
        x1 = 30,
        y0 = 0,
        y1 = 1,
        yref = "paper"
      )
    )
  ) %>%
  config(editable = TRUE)

reprex with only one shape - it works:

library(plotly)

p1 <- plot_ly(mtcars, x = ~mpg, y = ~hp)

p2 <- plot_ly(mtcars, x = ~mpg, y = ~drat)

subplot(p1, p2, nrows = 2) %>% 
  layout(
    shapes = list(
      type = "line", 
      line = list(color = "#5681c4", dash = "dot"),
      x0 = 20, 
      x1 = 20,
      y0 = 0,
      y1 = 1,
      yref = "paper"
    )
  ) %>%
  config(editable = TRUE)

Any thoughts?

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先运行 issue 中正常工作的和失败的 reprex,比较提供给每个 plot 的 shapes 与在 subplot() 之后添加的 shapes。跟踪 subplot() 如何组合这些 plot,以及后续的 layout(shapes = ...) 调用如何被处理。完成的标准是两个 shapes 都能在 subplot 中渲染,并且仍可通过 config(editable = TRUE) 编辑。

由索引模型根据 Issue 内容生成。

评估

技术栈
r
领域
data-visualization
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。