subplot crashes if add_annotation lacks x and y arguments
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2.7k
- Forks
- 641
- PR merge metrics
- No merged PRs in 30d
Description
If I create subplots that use add_annotation and don't pass in values for x and y, subplot crashes RStudio.
Using the example from https://plotly-r.com/bars-histograms.html#multiple-numeric-distributions, the original code works fine. The version below comments out x and y and causes RStudio to crash.
## DO NOT RUN
one_plot <- function(d) {
plot_ly(d, x = ~price) %>%
add_histogram() %>%
add_annotations(
~unique(clarity), # x = 0.5, y = 1,
xref = "paper", yref = "paper", showarrow = FALSE
)
}
diamonds %>%
split(.$clarity) %>%
lapply(one_plot) %>%
subplot(nrows = 2, shareX = TRUE, titleX = FALSE) %>%
hide_legend()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the supplied R reproducible example from the plotly-r.com bars and histograms page, focusing on add_annotations() with x and y omitted and the surrounding subplot() call. Trace how these entry points handle missing annotation coordinates. Done means the example no longer crashes RStudio when x and y are absent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100