plotly / plotly/plotly.R

Bug: ggplotly with no open plots crashes R (from Rgui)

Open
#1,150 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ggplotly
Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

Example:

library(ggplot2)
library(plotly)
p <- qplot(mpg, data=mtcars, geom="density", fill=gear, alpha=I(.5), 
   main="Distribution of Gas Milage", xlab="Miles Per Gallon", 
   ylab="Density")
ggplotly(p) # crashes R when used in RGui

The following would make gui not crash:

library(ggplot2)
library(plotly)
p <- qplot(mpg, data=mtcars, geom="density", fill=gear, alpha=I(.5), 
   main="Distribution of Gas Milage", xlab="Miles Per Gallon", 
   ylab="Density")
dev.new()
ggplotly(p) # crashes R when used in RGui

My session: (I'm using the latest ggplot2 and plotly)

> sessionInfo()
R version 3.4.1 (2017-06-30)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 7 x64 (build 7601) Service Pack 1

Matrix products: default

locale:
[1] LC_COLLATE=Hebrew_Israel.1255  LC_CTYPE=Hebrew_Israel.1255   
[3] LC_MONETARY=Hebrew_Israel.1255 LC_NUMERIC=C                  
[5] LC_TIME=Hebrew_Israel.1255    

attached base packages:
[1] stats     graphics  grDevices datasets  utils     methods   base     

other attached packages:
[1] plotly_4.7.1.9000  ggplot2_2.2.1.9000 installr_0.20.0    stringr_1.2.0     

loaded via a namespace (and not attached):
 [1] Rcpp_0.12.13        compiler_3.4.1      plyr_1.8.4         
 [4] bindr_0.1           tools_3.4.1         digest_0.6.12      
 [7] jsonlite_1.5        tibble_1.3.4        gtable_0.2.0       
[10] viridisLite_0.2.0   pkgconfig_2.0.1     rlang_0.1.4        
[13] shiny_1.0.3         crosstalk_1.0.0     yaml_2.1.14        
[16] bindrcpp_0.2        dplyr_0.7.4.9000    httr_1.3.1         
[19] htmlwidgets_0.9     grid_3.4.1          tidyselect_0.2.3   
[22] glue_1.2.0          data.table_1.10.4-3 R6_2.2.2           
[25] purrr_0.2.4         tidyr_0.7.2         magrittr_1.5       
[28] scales_0.5.0.9000   htmltools_0.3.6     assertthat_0.2.0   
[31] xtable_1.8-2        mime_0.5            colorspace_1.3-2   
[34] httpuv_1.3.5        labeling_0.3        stringi_1.1.5      
[37] lazyeval_0.2.1      munsell_0.4.3 

This was first found through: https://github.com/talgalili/heatmaply/issues/121

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the provided qplot and ggplotly example in RGui on Windows, then compare it with the same example after dev.new(). Trace the ggplotly handling of the graphics device and confirm the fix by verifying that the no-open-plot case no longer crashes R while the example still renders.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.