config-package does not update Plone version classifiers in setup.py

Open
#381 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
65/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
tooling

Research direction

Start by running uvx --from=plone.meta config-package --branch current . against a package whose classifiers are defined in setup.py, such as plone.app.registry. Trace how config-package updates version classifiers and compare the result with the existing setup.py. Done means the target Plone classifier is updated there, or the command clearly warns that manual changes are required.

Written by the indexing model from the issue text.

Description

01 type: bug

Describe the bug

When running config-package --branch current on a package that still defines its classifiers in setup.py (rather than setup.cfg or pyproject.toml), the Plone version classifier is not updated to reflect the current supported release.

To Reproduce

Steps to reproduce the behavior:

  1. Have a package with classifiers defined in setup.py (e.g. "Framework :: Plone :: 6.2")
  2. Run uvx --from=plone.meta config-package --branch current .
  3. Inspect setup.py — the classifier is unchanged

Expected behavior

The Plone version classifier in setup.py is updated to match the target branch (e.g. adding "Framework :: Plone :: 6.3"), or a warning is emitted telling the maintainer that classifiers in setup.py were not updated and must be handled manually

Software (please complete the following information):

  • Plone Version [e.g. 6.3.0]

Additional context

Package used is plone.app.registry

Dominant language
Python
Stars
6
Forks
7
Avg merge
2d 19h
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from plone/meta

All issues in plone/meta

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.