plone / plone/meta

PR from a fork should run the checks

Open
#372 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

04 type: enhancement
Dominant language
Python
Stars
6
Forks
7
Avg merge
2d 19h
Merged PRs (30d)
5

Description

In collective.honeypot we have this PR:
https://github.com/collective/collective.honeypot/pull/34
It is from a fork. No checks are run.

I pushed that branch to a branch with the same name on the collective, and made a new PR, and there the checks are run just fine:
https://github.com/collective/collective.honeypot/pull/35

I think we should change some condition in the workflows to allow running the checks in a PR from a fork as well.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the workflow behavior for pull requests 34 and 35, then inspect the repository's GitHub Actions workflow files for conditions that distinguish forked pull requests. Confirm the intended behavior and test the change with a pull request from a fork, verifying that the checks run without weakening workflow security.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.