phpmyadmin / phpmyadmin/sql-parser
CREATE AGGREGATE FUNCTION not handled
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 485
- Forks
- 119
- PR merge metrics
- No merged PRs in 30d
Description
Hello.
I found out that phpMyAdmin 5.2.2 is not handling stored aggregate functions defined as CREATE AGGREGATE FUNCTION described in :
https://mariadb.com/kb/en/stored-aggregate-functions/
I get an error if I define such function by any external mean and want to see it in phpMyAdmin.
Digging into the source code drove me inside this vendor sub-project, file src/Statements/CreateStatement.php.
I tried to add "'AGGREGATE' => 1," to the public static $OPTIONS member of the class CreateStatement into this file, line 36.
This is enough for no longer getting an error, but I suppose this is not enough for having phpMyAdmin properly handling stored aggregate functions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Statements/CreateStatement.php, especially the CreateStatement options mentioned in the report, and reproduce the MariaDB CREATE AGGREGATE FUNCTION case described in the issue. Compare its behavior with existing CREATE FUNCTION handling; done means the aggregate form no longer errors and is handled properly by the parser.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mariadb, php, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100