phpmyadmin / phpmyadmin/sql-parser

Error with parentheses around select statement

Open
#484 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
485
Forks
119
PR merge metrics
No merged PRs in 30d

Description

This statement produces an error.

INSERT INTO A (b) (SELECT 1)

The parentheses around the SELECT subquery are optional. The following works without an error:

INSERT INTO A (b) SELECT 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce both INSERT statements against the SQL parser and compare how the parenthesized SELECT is tokenized and parsed. Locate the parser entry point and existing syntax tests, then add coverage so INSERT INTO A (b) (SELECT 1) is accepted while preserving the working unparenthesized form.

Written by the indexing model from the issue text.

Assessment

Tech stack
mysql, php, sql
Domain
compilers, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.