phpmyadmin / phpmyadmin/sql-parser
CREATE TABLE statement not properly parsed or build
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- PHP
- Stars
- 485
- Forks
- 119
- PR merge metrics
- No merged PRs in 30d
Description
$sql = 'CREATE TABLE tab1 (`col1` TIMESTAMP /*!40100 DEFAULT NULL */)';
$parser = new Parser($sql);
$s3 = $parser->statements[0]->build();
// $s3 wrongly contains end-of-comment
// CREATE TABLE tab1 (
// `col1` timestamp DEFAULT NULL */
//)
//PHP 7.1.18
//"name": "phpmyadmin/sql-parser",
//"version": "5.0.0",
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PHP reproduction using Parser and statements[0]->build(), then inspect how the MySQL versioned comment in the CREATE TABLE statement is tokenized and rendered. Done means the generated SQL no longer includes the comment's closing marker after DEFAULT NULL, with regression coverage for this example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- mysql, php, sql
- Domain
- databases, devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100