SHA3-SHAKE (KECCAK) implementation
Nessuno ha ancora preso questa issue.
- Lingua principale
- C
- Stelle
- 40.4k
- Fork
- 8.1k
- Merge medio
- 2g 13h
- PR unite (30g)
- 96
Descrizione
Description
This is a very specific feature request and I don't really expect this to be added any time soon.
Since version 8.1 now supports an options array as an argument to the hash function, PHP could implement native support for the SHAKE128 and SHAKE256 algorithms that are part of KECCAK (SHA3).
Unfortunatly I could not find the original discussions from back when version 7.1 was released (when sha3 support was introduced), nor any other discussions about SHA3 for that matter, to find the reason why they were not implemented. My guess why they weren't implemented is that SHAKE has a variable output length that MUST be specified by the user and that back then there was no way to pass an option by the user to the hash implementation.
I am not too familiar with when and how often SHAKE algorithms are used in the wild, but I can't imagine that many people actually depend on them.
In my use case, we have a custom OAuth2 OpenID Connect implementation and have migrated from RSA to EdDSA token signing because a) EdDSA is faster and b) has a considerably shorter signature length. So that our PHP applications can fully support EdDSA with the curves like "Ed448", OpenID Connect requires SHAKE256 to generate the verification hashes like "s_hash" or "at_hash".
Since the options array is now available, the algorithm could be nicely integrated with the existing hash function:
<?php
print hash('sha3-shake256', 'This is a SHAKE256 test string. ', false, [
'output_length' => 114 // value from OpenID Connect
]);
// 3477218c282909fa2e1df2e7c3bc
Since this should not break BC, this feature could be implemented with a minor release.
Unfortunatly I have absolutly no experience with PHP internals and much much less knowledge of cryptograhy/hashing in general and therefore am unable to submit a PR myself.
Thank you for reading my feature request and much love and respect to the internals team.
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia con la funzione hash() di PHP e il relativo supporto per gli options-array, quindi esamina come vengono implementati gli algoritmi SHA3 negli interni di PHP. Conferma i requisiti di SHAKE128 e SHAKE256, inclusa una lunghezza dell’output specificata dall’utente e l’esempio OpenID Connect. Il lavoro è completato quando il supporto nativo per SHAKE produce l’output a lunghezza variabile richiesto senza interrompere il comportamento esistente.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- c, php
- Ambito
- cryptography
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 25/100