php / php/php-src

${} is deprecated without documenting new behaviour in PHP 9.0

Ouverte
#8,501 5 commentaires 2 réactions 1 personne assignée Voir sur GitHub

@iluuu1994 y travaille déjà.

Depuis le 6/5/2022.

Bug Category: Engine Status: Verified
Langage dominant
C
Étoiles
40.4k
Forks
8.1k
Merge moyen
2 j 13 h
PR mergées (30 j)
96

Description

Description

According to this accepted RFC, and according to https://github.com/php/php-src/pull/8212 , the following code is deprecated in PHP 8.2, and is scheduled for removal in PHP 9.0:

<?php
var_dump("${foo}");
// Deprecated: Using ${} in strings is deprecated
 
var_dump("${(foo)}");
// Deprecated: Using ${} (variable variables) in strings is deprecated

However, this RFC does not document what the behaviour will be in PHP 9.0. Will it raise a syntax error? Or will treat it like a plain string literal?

<?php
var_dump("${foo}");
// In PHP 9.0, will this raise a syntax error? Or will it be equal to '${foo}' ?
 
var_dump("${(foo)}");
// In PHP 9.0, will this raise a syntax error? Or will it be equal to '${(foo)}' ?

I think this is important to consider this question to help those migrating their codebase to PHP 9.0 in the future, and to alert those who may not realise this code may need modification. I personally propose that this raise a syntax error in PHP 9.0. Later versions can allow this syntax again, if needed, with the new behaviour of acting like a normal string literal with no special behaviour. This means that the migration path would be:

  1. Old syntax is supported
  2. Old syntax raises a deprecation warning, but works as before (PHP 8.2)
  3. Old syntax raises a syntax error (PHP 9.0)
  4. In the future, the old syntax may be allowed again, with the new behaviour
PHP Version

PHP 8.2

Operating System

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.