Unify dns_*() function definitions for all platforms
Open
Nobody has claimed this yet.
Category: DNS
Extension: standard
Feature
Status: Verified
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
This is a todo in the code
I'm putting it here so it gets on the radar for a todo.
If this is a wontfix then remove the todo from the code.
Changes to this code segment caused an issue #7748 with the output of gethostbyaddr() showing as a binary string in Windows.
/* TODO: Reimplement the gethostby* functions using the new winxp+ API, in dns_win32.c, then
we can have a dns.c, dns_unix.c and dns_win32.c instead of a messy dns.c full of #ifdef
*/
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TODO in ext/standard/dns.c around line 138, then compare the referenced dns.c, dns_unix.c, and dns_win32.c organization. Review issue #7748 for the Windows gethostbyaddr() regression. Done means either unifying the dns_*() definitions across platforms without that regression, or removing the TODO if the project decides it is a wontfix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100