Extends PDO, sqliteCreateFunction() and magic method __call()
未关闭
还没有人认领这个 Issue。
Extension: pdo (core)
Extension: pdo_sqlite
Feature
- 主要语言
- C
- 星标
- 40.4k
- 派生
- 8.2k
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 96
描述
Description
The following code:
<?php
declare(strict_types=1);
class DBStatement extends PDOStatement
{
protected $db;
protected function __construct(PDO $db)
{
$this->db = $db;
}
}
class db extends PDO {
public function __construct(string $dsn, string $username = null, string $password = null, array $options = [])
{
$options += [
self::ATTR_DEFAULT_FETCH_MODE => self::FETCH_ASSOC,
self::ATTR_EMULATE_PREPARES => false,
self::ATTR_STRINGIFY_FETCHES => false,
self::ATTR_ERRMODE => self::ERRMODE_EXCEPTION,
self::ATTR_STATEMENT_CLASS => [DBStatement::class, [$this]],
];
parent::__construct($dsn, $username, $password, $options);
$this->sqliteCreateFunction('CONCAT', function (...$args) {return \implode('', $args);});
}
public function __call(string $name, array $args) /* : mixed */
{
// Here is the loading of a class with rarely used methods that are different in implementation for different databases.
// In a real project, an exception is displayed:
// PHP OTHER_ERROR: Method 'sqliteCreateFunction' not found in DB driver. in ...\app\Core\DB\Sqlite.php:[70]
}
}
$db = new db('sqlite:datadb', '', '', []);
var_dump($db->query('SELECT CONCAT(\'123\', \'456\', \'789\')')->fetch());
exit;
Resulted in this output:
Fatal error: Uncaught PDOException: SQLSTATE[HY000]: General error: 1 no such function: CONCAT in C:\laragon\www\1.php:33 Stack trace: #0 C:\laragon\www\1.php(33): PDO->query('SELECT CONCAT('...') #1 {main} thrown in C:\laragon\www\1.php on line 33
But I expected this output instead:
array(1) { ["CONCAT('123', '456', '789')"]=> string(9) "123456789" }
It turns out that the call to the sqliteCreateFunction() method is intercepted by __call()?
P.S. In my project, I extended PDO, extended PDOStatement and use _call () to call rare methods to change the structure of the database. Now I got such an incident when using SQLite.
PHP Version
PHP 8.1.1-Win32-vs16-x64, 8.1.0, 8.0.8, 7.4.5, 7.3.33
Operating System
Windows 7 x64
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
运行提供的 PHP 复现程序,并从 issue 中描述的 PDO 子类、sqliteCreateFunction() 和 __call() 入口点开始。将缺失的 CONCAT 函数与预期的查询结果进行比较;当方法分派行为得到解决,或其限制已被明确确定时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- php, sqlite
- 领域
- databases
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100