php / php/php-src

strtotime() has strange interpretation of decimal weeks

Ouverte
#21,027 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

@derickr y travaille déjà.

Depuis le 24/1/2026.

Extension: date Feature Status: Requires RFC
Langage dominant
C
Étoiles
40.4k
Forks
8.2k
Merge moyen
2 j 13 h
PR mergées (30 j)
96

Description

Description

The following code:

<?php
strtotime("2.37685 weeks");

Resulted in this output:

1613443020

The code interpreted 2.37685 weeks as 02:37 (hours) and 685 weeks. This is non logical input of course (and not GNU compliant). But this isn't a very logical interpretation of this value from a human perspective and can easily be used incorrectly by users of the code without noticing.

The parser decided to not be able to recognize weeks, then fallback to hours, interpret up to 2 decimals (compliant with hour parsing), then split the remainder and continue parsing, interpreting the rest as the input for weeks.

This has been a known (usability) issue since 2007, when it was first encountered by Wikipedia, but an upstream ticket was never filed until now.

I consider this a usability pitfall of this function, that in my opinion should be rectified

  • it is illogical that a decimal is cutoff at 2 places
  • the cutoff value is assigned an implicit unit
  • the remainder of the value is suddenly a NEW secondary input
  • it adds both of them to form something way bigger than the user had expected

I suggest that if a decimal is recognized and unit is weeks, that this function throws a warning (recognize but don't accept)

PHP Version
PHP 8.4.16 (cli) (built: Dec 16 2025 16:03:34) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.4.16, Copyright (c) Zend Technologies
    with Xdebug v3.4.0, Copyright (c) 2002-2024, by Derick Rethans
    with Zend OPcache v8.4.16, Copyright (c), by Zend Technologies
Operating System

macos

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.