file_get_contents should probably clear the global state of last headers

Description

The following code:

<?php

file_get_contents(__FILE__);
var_dump(http_get_last_response_headers());

file_get_contents('https://php.net/');
var_dump(http_get_last_response_headers());

file_get_contents(__FILE__);
var_dump(http_get_last_response_headers());

Resulted in this output:

NULL
array( headers from php.net )
array( headers from php.net )

But I expected this output instead:

NULL
array( headers from php.net )
NULL // as reading a file clearly outputs no headers

IMO this is very surprising, and can lead to bugs (see https://github.com/jsonrainbow/json-schema/pull/843 for example) as people are now nudged to switch to http_get_last_response_headers() by the deprecations.

The problem is that $http_response_headers, while a very ugly API, was a local variable.. and http_get_last_response_headers() while appearing cleaner stores global state and can thus leak data across boundaries if you do not call http_clear_last_response_headers() after fetching the headers.

Thus my suggestion would be that file_get_contents first clears the headers and then populates them if the stream wrapper in use has anything to populate.

/cc @Girgias as I know you were involved in the deprecation. And apologies if this was already discussed somewhere I didn't find.

PHP Version

All versions where `http_get_last_response_headers()` is available

Operating System

No response

Commence par exécuter la reproduction PHP de l’issue et lire les implémentations de file_get_contents(), http_get_last_response_headers() et http_clear_last_response_headers(). Suis la manière dont les wrappers de flux mettent à jour les en-têtes stockés, puis ajoute une couverture montrant que la lecture d’un fichier local efface les en-têtes laissés par une requête HTTP précédente ; le travail est terminé lorsque le dernier appel renvoie NULL.