FPM vs CLI - getcwd() !== $_SERVER['DOCUMENT_ROOT'] and include_path
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
I'm not yet sure whether this is a bug or an improvement in documentation suffices.
$_SERVER['DOCUMENT_ROOT'] is set by the FPM SAPI (therefore also in INPUT_SERVER 'DOCUMENT_ROOT') and should generally be equal to nginx's root ($document_root) path
However, there is also getcwd() which, unless set in www.conf chdir and modified in https://github.com/php/php-src/blame/master/sapi/fpm/fpm/fpm_unix.c#L457 which should be identical to DOCUMENT_ROOT.
However it is not.
e.g.
root /foo/bar
request: /hello/world.php
which is located in /foo/bar/hello/world.php
DOCUMENT_ROOT will be /foo/bar
but getcwd() will be /foo/bar/hello (essentially dirname( $_SERVER['SCRIPT_FILENAME'] ) )
I'm unable to find where this change of directory happens though - since it's not in https://github.com/php/php-src/blame/master/sapi/fpm/fpm/fpm_unix.c#L457 and there are no other chdir happening.
Could anyone pinpoint this?
php-fpm 5.2 (?) seemed to have
https://linux.die.net/man/8/php-fpm
-C
Do not chdir to the script's directory
which was removed though (I couldn't find details on why though)
This generally is not an issue, however it might be extremely unexpected when using exec() for example.
Would it not make more sense if by default the fpm SAPI would use the DOCUMENT_ROOT by default as cwd?
Where it becomes confusing though is:
https://www.php.net/manual/en/ini.core.php#ini.include-path
Using a . in the include path allows for relative includes as it means the current directory.
"current directory" means DIR and not getcwd() ?
Except in CLI:
https://www.php.net/manual/en/features.commandline.differences.php
The CLI SAPI does not change the current directory to the directory of the executed script.
where it means getcwd() and not DIR ?
Would it make sense to somehow standardize eventually?
Sorry, if this reads confusing, but so am I atm
PHP Version
8.4
Operating System
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with sapi/fpm/fpm/fpm_unix.c around the referenced line and the www.conf chdir setting, then compare the FPM and CLI behavior described in the linked documentation. Done means identifying where the working directory changes and determining whether the behavior or the include-path documentation needs clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx, php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100