php / php/php-src

Trait property conflicts silently drop attributes

Ouverte
#19,466 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Bug Status: Needs Triage
Langage dominant
C
Étoiles
40.4k
Forks
8.2k
Merge moyen
2 j 15 h
PR mergées (30 j)
103

Description

Description
Summary

When multiple traits define properties with identical signatures but different attributes, PHP silently drops attributes during trait composition without any notice or warning.

Affected versions: PHP 8.0+ (since attributes were introduced)

Problem Description

PHP's trait system correctly handles method conflicts by throwing fatal errors when methods with the same name exist in multiple traits. However, when properties with identical signatures but different attributes are defined in multiple traits, PHP:

  1. Correctly merges the property (no fatal error)
  2. Silently drops attributes from one of the traits
  3. Provides no indication that attributes were lost
  4. Behavior is unpredictable (depends on trait order)

This creates silent data loss where code appears correct but attributes are missing.

Expected Behavior

When trait properties have identical signatures but different attributes, PHP should at minimum emit a notice or warning:

Notice: Trait property 'propertyName' has conflicting attributes during trait composition in %s on line %d
Reproduction Code
<?php

#[Attribute]
class Column {}

#[Attribute] 
class Version {}

// Trait 1: Property with Column attribute
trait BasicTrait {
    #[Column]
    private ?string $data = null;
}

// Trait 2: Same property with Column AND Version attributes
trait VersionedTrait {
    #[Column]
    #[Version]
    private ?string $data = null;
}

class TestEntity {
    use BasicTrait;
    use VersionedTrait; // Version attribute should be preserved
}

// Check what actually happened
$reflection = new ReflectionClass(TestEntity::class);
$property = $reflection->getProperty('data');
$attributes = $property->getAttributes();

echo "Total attributes: " . count($attributes) . "\n";
foreach ($attributes as $attr) {
    echo "- " . $attr->getName() . "\n";
}

$versionAttrs = $property->getAttributes(Version::class);
echo "Version attributes: " . count($versionAttrs) . "\n";

if (count($versionAttrs) === 0) {
    echo "BUG: Version attribute silently dropped!\n";
}
Expected Output
Notice: Trait property 'data' has conflicting attributes during trait composition in %s on line %d
Total attributes: 1
- Column
Version attributes: 0
BUG: Version attribute silently dropped!
Actual Output
Total attributes: 1
- Column
Version attributes: 0
BUG: Version attribute silently dropped!
Why This Is a Bug
  • Inconsistent: Method conflicts properly throw fatal errors
  • Silent data loss: PHP usually warns about potential issues
  • Unpredictable: Same code behaves differently based on trait order
  • No workaround: Cannot use insteadof or as with properties
Proposed Fix

Emit a notice/warning when attributes are dropped during trait property merging (minimum viable fix).

PHP Version
PHP 8.2.28 (cli) (built: Mar 11 2025 17:58:12) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.28, Copyright (c) Zend Technologies
    with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans
    with Zend OPcache v8.2.28, Copyright (c), by Zend Technologies
Operating System

No response

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par la reproduction mettant en jeu BasicTrait, VersionedTrait et ReflectionClass, et exécutez-la dans l’environnement PHP 8.2.28 signalé afin d’observer la composition des propriétés des traits. Suivez le chemin de composition des traits de l’interpréteur PHP et ajoutez une couverture montrant que des attributs de propriété différents produisent le diagnostic attendu sans perte silencieuse d’informations.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
php
Domaine
compilers
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
38/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.