set_exception_handler not restored if calling exit within itself

Description

What was fixed https://github.com/php/php-src/commit/3301d9602a2307007858c299c41795d3d95e3843 https://github.com/php/php-src/issues/13446#issuecomment-1991549384 bc it was broken from 8.3.0-8.3.4 is still broken if the exception handler itself calls exit.

https://3v4l.org/HkWfh
without exit: https://3v4l.org/FTWQf

The following code:

<?php

declare(strict_types=1);

function foo($e) {
    var_dump( set_exception_handler('foo') );
    restore_exception_handler();
    echo "---" . PHP_EOL;
    exit;
}

set_exception_handler('foo');

register_shutdown_function(function () {
    var_dump( set_exception_handler(null) );
});

strlen(null);

Resulted in this output:

NULL
---
NULL

But I expected this output instead:

NULL
---
string(3) "foo"

This matters, because since PHP 8.3, the exit code of the exit() call in exception handler is used as exit code of PHP

@iluuu1994

PHP Version

PHP 8.3.0+

Operating System

No response

Comienza reproduciendo el comportamiento con el script de PHP proporcionado y compara los casos con exit y sin exit de los ejemplos de 3v4l enlazados. Sigue la interacción entre set_exception_handler(), restore_exception_handler(), register_shutdown_function() y exit en el runtime de PHP. Se considera terminado cuando el callback de shutdown observa el handler "foo" restaurado al llamar a exit dentro del exception handler.