php / php/php-src

DateTime::diff() miscounts hours in days where a DST transition happens

未关闭
#18,393 4 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@derickr 已经在做这个了。

开始于 2025年4月22日。

Bug Extension: date Status: Needs Triage
主要语言
C
星标
40.4k
派生
8.2k
平均合并
2 天 13 小时
30 天内合并 PR
96

描述

Description

The following code:

<?php

$ref = new DateTime('2024-01-01 00:00:00', new DateTimeZone('Europe/Berlin'));
$t1 = new DateTime('2024-03-31 12:00:00', new DateTimeZone('Europe/Berlin'));
$t2 = new DateTime('2024-04-01 12:00:00', new DateTimeZone('Europe/Berlin'));
$t3 = new DateTime('2024-10-27 12:00:00', new DateTimeZone('Europe/Berlin'));
$t4 = new DateTime('2024-10-28 12:00:00', new DateTimeZone('Europe/Berlin'));

// DST start
$diff1 = $ref->diff($t1);
$diff2 = $ref->diff($t2);
// DST end
$diff3 = $ref->diff($t3);
$diff4 = $ref->diff($t4);

echo('DST start' . PHP_EOL);
var_dump($diff1->h, $diff2->h);

echo('DST end' . PHP_EOL);
var_dump($diff3->h, $diff4->h);

Resulted in this output:

DST start
int(11)
int(12)
DST end
int(12)
int(12)

But I expected this output instead:

DST start
int(12)
int(12)
DST end
int(12)
int(12)

https://3v4l.org/VkM09

As far as I understand it DateTime::diff() is supposed to count the time based on the local clock of a time zone.
But on the day of a forward time transition when DST starts (2024-03-31), DateTime::diff() only counts 11 hours when the time on the local clock is actually 12 o'clock.

This is also inconsistent with the day of a backwards time transition when DST ends (2024-10-27), where DateTime::diff() still counts 12 hours when actually 13 hours have elapsed.

This issue started with PHP version 8.1. Prior versions work correctly.

PHP Version

PHP 8.1.32 (cli) (built: Mar 13 2025 18:27:44) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.32, Copyright (c) Zend Technologies
with Zend OPcache v8.1.32, Copyright (c), by Zend Technologies

Operating System

Ubuntu 24.04.1

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。