php / php/php-src

DateTime::diff() miscounts hours in days where a DST transition happens

Open
#18,393 4 comments 0 reactions 1 assignee View on GitHub

@derickr is already working on this.

Since Apr 22, 2025.

Bug Extension: date Status: Needs Triage
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

The following code:

<?php

$ref = new DateTime('2024-01-01 00:00:00', new DateTimeZone('Europe/Berlin'));
$t1 = new DateTime('2024-03-31 12:00:00', new DateTimeZone('Europe/Berlin'));
$t2 = new DateTime('2024-04-01 12:00:00', new DateTimeZone('Europe/Berlin'));
$t3 = new DateTime('2024-10-27 12:00:00', new DateTimeZone('Europe/Berlin'));
$t4 = new DateTime('2024-10-28 12:00:00', new DateTimeZone('Europe/Berlin'));

// DST start
$diff1 = $ref->diff($t1);
$diff2 = $ref->diff($t2);
// DST end
$diff3 = $ref->diff($t3);
$diff4 = $ref->diff($t4);

echo('DST start' . PHP_EOL);
var_dump($diff1->h, $diff2->h);

echo('DST end' . PHP_EOL);
var_dump($diff3->h, $diff4->h);

Resulted in this output:

DST start
int(11)
int(12)
DST end
int(12)
int(12)

But I expected this output instead:

DST start
int(12)
int(12)
DST end
int(12)
int(12)

https://3v4l.org/VkM09

As far as I understand it DateTime::diff() is supposed to count the time based on the local clock of a time zone.
But on the day of a forward time transition when DST starts (2024-03-31), DateTime::diff() only counts 11 hours when the time on the local clock is actually 12 o'clock.

This is also inconsistent with the day of a backwards time transition when DST ends (2024-10-27), where DateTime::diff() still counts 12 hours when actually 13 hours have elapsed.

This issue started with PHP version 8.1. Prior versions work correctly.

PHP Version

PHP 8.1.32 (cli) (built: Mar 13 2025 18:27:44) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.32, Copyright (c) Zend Technologies
with Zend OPcache v8.1.32, Copyright (c), by Zend Technologies

Operating System

Ubuntu 24.04.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.