php / php/php-src

Interactive shell doesn't complete property names

未关闭
#17,670 3 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Extension: readline Feature SAPI: cli
主要语言
C
星标
40.4k
派生
8.2k
平均合并
2 天 15 小时
30 天内合并 PR
103

描述

Description

According to the documentation:

The interactive shell also features tab completion for functions, constants, class names, variables, static method calls and class constants.

Only function, class and method names seems to be completing when hitting the TAB key.

Also, the completion is not contextualized: after $, it should be only variable names (not function and class names), and after -> it should be only property and method names of the current object.

The following command to run the interactive shell:

php -a
Completion of variable name

The following shell code:

php > $container = 'hello';
php > $co [⇥TAB]

Resulted in this output:

Collator                     collator_get_strength        constant                    
collator_asort               collator_set_attribute       convert_uudecode            
collator_compare             collator_set_strength        convert_uuencode            
collator_create              collator_sort                copy                        
collator_get_attribute       collator_sort_with_sort_keys cos                         
collator_get_error_code      compact                      cosh                        
collator_get_error_message   CompileError                 count                       
collator_get_locale          connection_aborted           count_chars                 
collator_get_sort_key        connection_status            Countable     

But I expected this output instead:

$container
Completion of property name

The following shell code:

php > $object = (object) ['foo' => 'bar'];
php > $object->fo [⇥TAB]

Resulted in this output:

fopen                     forward_static_call       forward_static_call_array

But I expected this output instead:

foo
PHP version
PHP 8.4.3 (cli) (built: Jan 15 2025 01:03:17) (NTS)
Copyright (c) The PHP Group
Built by Homebrew
Zend Engine v4.4.3, Copyright (c) Zend Technologies
    with Xdebug v3.4.1, Copyright (c) 2002-2025, by Derick Rethans
    with Zend OPcache v8.4.3, Copyright (c), by Zend Technologies
PHP Version

PHP 8.4.3

Operating System

Mac 15.3 (24D60)

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先运行 php -a,并复现 issue 中的变量和属性补全示例。跟踪交互式 shell 的补全入口点,并确定当前候选项是如何选择的。当 $co 只补全为 $container,且 $object-\u003efo 补全为 foo,同时保留文档中所述的补全行为时,即视为完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
php
领域
cli
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。