php / php/php-src

Use NumberFormatter instead of legacy NumberFormat

Open
#17,006 4 comments 0 reactions 1 assignee View on GitHub

@devnexen is already working on this.

Since Dec 6, 2024.

Extension: intl Feature Status: Needs Triage
Dominant language
C
Stars
40.4k
Forks
8.1k
Avg merge
2d 13h
Merged PRs (30d)
96

Description

Description

The following code:

<?PHP
function nth(int $number) : ?string {
		$formatter = new \NumberFormatter('en_US', \NumberFormatter::ORDINAL);
		$formatted = $formatter->format($number);
		return $formatted === false ? null : $formatted;
}

echo nth(651959195189);
?>

Resulted in this output:

651,959,195,189rd

But I expected this output instead:

651,959,195,189th
PHP Version

PHP 8.3.6

Operating System

Linux Mint 22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.