Add support for SCRAM-SHA-*-PLUS channel binding in PHP streams (e.g., tls-unique, tls-exporter)
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C
- Estrellas
- 40.4k
- Forks
- 8.2k
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 96
Descripción
Description
Hello,
I'm the maintainer of the fabiang/sasl library, which implements various SASL mechanisms. Since many SASL mechanisms have been deprecated over the years due to security issues, I am interested in improving the security of the SCRAM-SHA-* SASL mechanisms.
The SCRAM-SHA-*-PLUS mechanisms offer better security through channel binding. The recommended channel binding types are:
- tls-unique for TLS <= 1.2
- tls-server-end-point
- tls-exporter for TLS >= 1.3
Currently, PHP lacks support for channel binding, as no API is exposed to access data from the underlying secure socket. Additionally, more and more server software is adding support for channel binding.
For example, Python:
- supports at least "tls-unique" through SSLSocket.get_channel_binding
- and has an open Pull Request for tls-exporter.
To enable this in PHP, a simple API to retrieve channel binding data from a stream context would be beneficial.
A potential function could:
- return data from OpenSSL's
SSL_get_peer_finishedwhen channel binding is set to "tls-unique" and TLS 1.2 is used, - use OpenSSL's
SSL_export_keying_materialwhen channel binding is set to "tls-exporter" and TLS <= 1.3 is used, - trigger a warning when "tls-unique" is used with TLS 1.3,
- and trigger an error if the stream or context is not a TLS connection.
(Note: "tls-exporter" should also be supported on TLS 1.2 connections.)
stream_crypto_channel_binding(resource $stream_or_context, string $channel_binding_type): string;
Making this function compatible with both streams and contexts should cover all use cases.
Thank you.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza revisando las APIs de PHP streams y stream-context y, después, las interfaces de OpenSSL mencionadas en el issue: SSL_get_peer_finished y SSL_export_keying_material. Se considera completado cuando una API documentada puede recuperar los datos de channel binding solicitados para streams o contextos TLS e informa de los casos especificados de conexión no compatible y de versión de TLS; el payload no menciona archivos de implementación ni tests.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- c, php
- Área
- api, security
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 32/100