php / php/php-src

Include the configured max_children in the fpm status page

Ouverte
#16,221 2 commentaires 1 réaction 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Feature SAPI: fpm
Langage dominant
C
Étoiles
40.4k
Forks
8.1k
Merge moyen
2 j 13 h
PR mergées (30 j)
96

Description

Description

Hello,

We want to use the FPM Status Page to monitor for PHP worker exhaustion. We use the process manager ondemand, and we have noticed that we are lacking the data that shows how many children could potentially be created (the max_children directive).

The FPM status looks like this:

{
  "pool": "moodletes_89",
  "process manager": "ondemand",
  "start time": 1727966418,
  "start since": 119,
  "accepted conn": 18,
  "listen queue": 0,
  "max listen queue": 0,
  "listen queue len": 0,
  "idle processes": 1,
  "active processes": 0,
  "total processes": 1,
  "max active processes": 5,
  "max children reached": 0,
  "slow requests": 0,
  "processes": [
    {
      "pid": 2118218,
      "state": "Idle",
      "start time": 1727966430,
      "start since": 107,
      "requests": 9,
      "request duration": 129,
      "request method": "GET",
      "request uri": "opcache.php",
      "content length": 0,
      "user": "-",
      "script": "/usr/local/src/opcache.php",
      "last request cpu": 0,
      "last request memory": 2097152
    }
  ]
}

Here we do have max active processes, which shows the amount of processes that have been active at any point. This eventually grows to the max_children on a busy site, but after a restart it resets.
We also have idle_processes, but since we use ondemand as the process manager, we can not use this value for determing how much headroom there is, as more processes are spawned automatically (until max_children is reached).

Would it be possible to expose the max_children directive, so we can determine when all workers are busy and no more workers can be created?

As a sidenote, we originally tried to achieve this by monitoring the listen queue > 0, however it seems this value does not work when FPM is configured with a unix-socket, and only works on TCP/IP sockets. Due to this we cannot use this method either.

Thank you!

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par suivre la génération de la page d’état de FPM et l’endroit où la directive max_children configurée est lue. Ajoutez la valeur à la sortie d’état et vérifiez que la page l’expose pour le gestionnaire de processus ondemand.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
c, php
Domaine
backend, observability
Type d'issue
Fonctionnalité
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.