php / php/php-src

Objects implementing ArrayAccess cannot discern appended values or setting a value with a NULL offset.

未关闭
#13,992 2 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@Girgias 已经在做这个了。

开始于 2024年4月17日。

Feature Status: Verified
主要语言
C
星标
40.4k
派生
8.2k
平均合并
2 天 13 小时
30 天内合并 PR
96

描述

Description

While arrays treat $arr[] = 1 and $arr[NULL] = 1 as different operations, with the latter key being juggled to "", ArrayAccess::offsetSet() can only be passed NULL as the key in both cases, leaving the implementer to choose to either append the value to the array or set the "NULL" index.

The following code: https://3v4l.org/KIt91

<?php

class AATest implements ArrayAccess {
    protected $array = [];
    
    // ArrayAccess interface
    public function offsetExists(mixed $offset): bool {
        return key_exists($offset, $this->array);
    }
    public function offsetGet(mixed $offset): mixed {
        return $this->array[$offset];
    }
    public function offsetSet(mixed $offset, mixed $value): void {
        if( is_null($offset) ) {
            $this->array[] = $value;
        } else {
            $this->array[$offset] = $value;
        }
    }
    public function offsetUnset(mixed $offset): void {
        unset($this->array[$offset]);
    }
    
    // debug
    public function dbgGetArray() {
        return $this->array;
    }
}

$object = new AATest();
$object[] = 'a';
$object[NULL] = 'b';
$object[] = 'c';

var_dump($object->dbgGetArray());

$array = [];
$array[] = 'a';
$array[NULL] = 'b';
$array[] = 'c';

var_dump($array);

Resulted in this output:

array(3) {
  [0]=>
  string(1) "a"
  [1]=>
  string(1) "b"
  [2]=>
  string(1) "c"
}
array(3) {
  [0]=>
  string(1) "a"
  [""]=>
  string(1) "b"
  [1]=>
  string(1) "c"
}

But I expected this output instead:

array(3) {
  [0]=>
  string(1) "a"
  [""]=>
  string(1) "b"
  [1]=>
  string(1) "c"
}
array(3) {
  [0]=>
  string(1) "a"
  [""]=>
  string(1) "b"
  [1]=>
  string(1) "c"
}

With a few tweaks you can make 3v4l show that this has been the case all the way back to 5.0.0: https://3v4l.org/OC9qQ

I believe that in order to address this discrepancy there should be another method added to ArrayAccess specifically to handle an append, eg: ArrayAccess::appendValue(mixed $value): void, which would be invoked in the case of $obj[] = 1.

Of course, this would be a BC break, but the prior functionality would be easily restored via defining:

public function appendValue(mixed $value): void {
    $this->offsetSet(NULL, $value);
}

Alternately, NULL could simply be disallowed as a valid array offset entirely. Another BC break, but fixable with $array[$maybeNull ?: ""].

PHP Version

PHP >= 5.0.0

Operating System

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。