php / php/php-src

FPM: Always use script name in PHP_SELF if cgi.discard_path = 1 and cgi.fix_pathinfo = 0

未关闭
#11,025 2 条评论 1 个 reaction 已指派 1 人 在 GitHub 查看

@bukka 已经在做这个了。

开始于 2023年4月7日。

Feature SAPI: fpm
主要语言
C
星标
40.4k
派生
8.1k
平均合并
2 天 13 小时
30 天内合并 PR
96

描述

Description

Currently if PATH_INFO set, then it is used in PHP_SELF if cgi.fix_pathinfo is disabled. This makes sense if the executable is used from PATH_TRANSLATED which is default behaviour. However if cgi.discard_path is enabled, it uses SCRIPT_FILENAME executable instead. This however does not match the documentation which states that PHP_SELF is relative path to the executable because PATH_INFO has nothing to do with executable path.

This was first mentioned in https://bugs.php.net/bug.php?id=68053 and this issue is an extraction of that problem (the primary concern won't be fixed due to a significant BC break). Even though this could be considered as a bug, it is not that critical and it has some BC break concern. It means it should be treated more as a feature change to improve the current behaviour and should go only to master and be mentioned in UPGRADING.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。