Check UTF-8 validity for all constant strings on compile time
Ouverte
@iluuu1994 y travaille déjà.
Depuis le 17/3/2023.
Feature
Status: Needs Triage
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.1k
- Merge moyen
- 2 j 13 h
- PR mergées (30 j)
- 96
Description
Description
Currently the UTF-8 string validity is checked on demand and cached the string if not interned.
However:
- when a string is interned, such flag cannot be cached on runtime (at least not due TS)
- it is not stored back to the source script cache/opcache, ie. the validity is checked on every request at least once
- when a string is created from unvalidated source before checking, the validation cannot be cached
- currently only "valid UTF-8" flag is cached , but when a string is "invalid UTF-8", nothing is cached at all
This is a feature request to:
a) check UTF-8 validity on compile time on every const string
b) store a flag if UTF-8 validity was checked or not
Thanks to #10436 the UTF-8 validity check is very fast and the compile time impact should be minimal.
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.