phetsims / phetsims/rosetta

Simplify retrieval of the English string values

Open
#470 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

priority:5-deferred
Dominant language
TypeScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

As of this writing, Rosetta determines which strings are used in a simulation - and thus need to be translated - by getting the English string map build artifact, extracting all the strings keys, then pulling their English values from GitHub. The reasons it's done this way are historical, and I won't go into the details here, but I believe this process could be significantly simplified such that the keys and values are all taken from the string map file with no need to hit GitHub. This would lead to simpler code and better performance.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.