Warn user about unsaved changes before they navigate away
@liammulh is already working on this.
Since May 17, 2023.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
One of the features we wanted to add to Rosetta 2 was the ability to warn the user that they have unsaved changes before they navigate away from the translation form. Unfortunately, our client-side routing library (React Router) dropped support for this feature in V6. They plan on adding it back in. Once they add it back in, we can implement this feature.
I don't want to revert back to V5 because it would require a fair amount of refactoring that would be have to be reverted to what it currently is when we upgrade to V6, which seems like a lot of work for very little benefit. Also, this was one of the "if it's easy" requests for Rosetta 2.
The React Router issue for this is: https://github.com/remix-run/react-router/issues/8139.
Draft PR for the feature request here: https://github.com/remix-run/react-router/pull/9709.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.