phetsims / phetsims/rosetta

i18n: Add option to use comma as decimal separator instead of period

Open
#263 27 comments 0 reactions 1 assignee View on GitHub

@jbphet is already working on this.

Since Dec 5, 2019.

priority:5-deferred type:epic type:i18n
Dominant language
TypeScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Unless there is other repo/mechanism to handle with internationalization, i would suggest to include dot in babel, with a parameter to allow translators to select the decimal separator, and make proper replacement in Utils.toFixed().
As always..., thanks for this great simulations!!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.