phetsims / phetsims/rosetta

Sim translation updates for common string changes

Open
#197 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority:5-deferred
Dominant language
TypeScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

@jbphet, I'm curious if a common string change submitted for some sim that includes common string changes (say, a JOIST string that affects all sims) would trigger a build/update for ALL sims that include that string?

A brief scan of the code (and my memory) would think that only the sim that was "submitted" would get rebuilt with the translation.

During dev meeting today, it was discussed that we might WANT to rebuild all sims/locales that are affected by the string changes, not just the submitted sim.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how a submitted sim's common-string translation changes trigger builds and updates across sims and locales. Define the affected-sim set and verify that every sim using the changed common string is rebuilt and updated, rather than only the submitted sim.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
localization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.