pharmaverse / pharmaverse/rtables
Add tests to have one single form of `MatrixPrintForm` that is identical to the one generated by `basic_matrix_form`
Open
Nobody has claimed this yet.
enhancement
sme
- Dominant language
- R
- Stars
- 260
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
A couple of differences:
-
attributes(b$spans) # To do in original: remove dimnames -
b$row_info$node_class # to remove from original: attribute package rtables?? -
compare_mf(a, b, TRUE) # indent in row_info should be different. Current fix -
b$formats[, 1] <- rep("", nrow(b$formats)) # To check original: We need to remove these spaces from formats?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating MatrixPrintForm, basic_matrix_form, and compare_mf in the repository, then inspect existing tests around those entry points. Compare the remaining unchecked differences in attributes(b$spans), b$row_info$node_class, and b$formats[, 1]. Done means tests establish one MatrixPrintForm representation identical to the form generated by basic_matrix_form.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100