pharmaverse / pharmaverse/formatters
request additional format for list_valid_format_labels()
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 20
- Forks
- 8
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 1
Description
When using the 2d format string with parentheses I'd like list_valid_format_labels to support 3 decimal places in both the first and second entries e.g. xx.xxx (xx.xxx)
Currently I have to choose either to use a slash instead of parentheses with "xx.xxx / xx.xxx" or reduce to 2 dp's for the first entry with "xx.xx (xx.xxx)"
Thanks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at list_valid_format_labels() and trace how 2d format strings with parentheses are validated, comparing the existing slash form and the two-decimal first-entry form described in the issue. Done means the parenthesized format xx.xxx (xx.xxx) is accepted while existing formats continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100