pharmaverse / pharmaverse/formatters
`nlines` is user-facing but it does not work on general tables
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 20
- Forks
- 8
- Avg merge
- 12h 28m
- Merged PRs (30d)
- 1
Description
I was trying to get the global number of lines without having to get nlheader from matrix_form. So, I guess, the first question is the following: is there a function to find the total number of lines? if yes, we should document it in rtables::nrow. See here for a follow-up on this. If not, we should have one and intuitively I was searching for rtables::nlines but maybe too a specific variable in nrow like this rtables::nrow(..., with_header = T). Let me know what you think @gmbecker
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the user-facing nrow and nlines behavior for general tables, along with the referenced matrix_form and rtables issue. Determine whether an existing function reports total lines or whether a new API is needed, then document or specify the chosen behavior and its handling of headers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100