pepkit / pepkit/pephub

Evaluate JWT at the correct time

Open
#385 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority low
Dominant language
TypeScript
Stars
22
Forks
2
PR merge metrics
No merged PRs in 30d

Description

This issue is a spinoff of #377.

Right now, we're evaluating the JWT (including checking for an expired token) even for public requests. This is because we evaluate the JWT if it's given, in the dependencies.

Instead, we should restructure this to do the JWT validation only if something private was requested. So whether we evaluate the JWT shouldn't be modulated at the level of endpoints; it should instead be at the level of privacy-vs-not.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing where dependency evaluation currently validates a supplied JWT and how requests are classified as public or private. Done means public requests no longer evaluate or reject expired JWTs, while private requests still perform JWT validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, authentication, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.