pepkit / pepkit/pephub

Improving the views interface

Open
#370 2 comments 0 reactions 1 assignee View on GitHub

@sanghoonio is already working on this.

Since Aug 26, 2024.

enhancement UI/UX
Dominant language
TypeScript
Stars
22
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Views suggestions

  1. The interface for adding a view right now is not explained anywhere, and is unintuitive. It could be either:

    • In the "Manage Views" modal, keep the "Save view" section (right now it is simply absent if there is no filter applied). If no filter is applied, then just show a brief explanation that says "No filter has been applied. To save a view, apply a filter using the column drop downs to select a subset of rows". This would go away if a filter has been applied. (preferred)
    • add a "Save View" button to the main interface; if it's clicked without a filter, pop up a modal explaining how the filter works (less preferred)
  2. For removing/selecting a view: I find it unintuitive that the Default is "No view", which you get by "Closing" the view. Instead, I find it more intuitive if the default is one of the view options. So, under "Select a view", I should be able to select "No view" or "Default view" or "Entire table", instead of having to click the "x" to "remove" the view.

  3. The tooltip is annoying me. it comes up literally every time I mouse over the views button. It also doesn't disappear when I click it. It should disappear when I click it. It should be triggered by a little "info/help" button" instead of a mouseover? I suggest we start to add little question marks with circles (?) and when you click that, you get a little explainer.

  4. Minor concern, but ideally, "Add View" and "Remove View" should be Tabs in the modal, rather than vertical

  5. Minor concern: There's no mechanism to edit the description of a view. Maybe this is for the future.

  6. It's strange to me that the view cannot be edited by the HandsOnTable interface.

  7. Right now, opening a view makes the table read-only. This doesn't make sense to me; the view should allow editing of a subset of the files. That is kind of the point, to allow us to see and interact with just a few of the samples.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.