patternfly / patternfly/react-data-view
Consistency: Add chip toolbar buttons to all DataView filters to match TreeViewFilter
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
During a recent PR review, we noticed that the DataViewTreeViewFilter contains an extra button in the chip toolbar that isn't present in other data-view filters:
This is, however, as per the examples I found in PatternFly documentation, the correct behaviour for filters:
Could you please implement this behaviour to the rest of the data-view filters?
Many thanks for considering the change!
Jira Issue: PF-4106
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing DataViewTreeViewFilter with the other data-view filters and review the linked PatternFly filter examples. Update the remaining filters to provide the same chip-toolbar button behavior, then verify that all data-view filter variants are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100