patternfly / patternfly/patternfly-react
Spike - Investigate options for updating a11y props being required or not
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the enhancement or change
Spike for a discussion to have regarding https://github.com/patternfly/patternfly-react/issues/5397
Basically we need to decide whether:
-
we want to update certain a11y props to either be required (if currently optional) or make them optional (if currently required)
-
we want to add console warnings when an optional a11y prop is not passed in, but ideally should be (e.g. if an element doesn't have a visible text label, typically we should want an
aria-labeladded somewhere) -
leave things as-is - props will remain optional or required as they already are
-
some combination of all of the above
-
some props should have an (updated?) default value
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
Any other information?
Jira Issue: PF-108
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先阅读链接的 PatternFly issue #5397,并检查受影响组件当前必需和可选的可访问性 props。比较此处描述的选项,包括警告和默认值。当替代方案、受影响的 props 以及建议的方向都已记录下来供讨论时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 冷清
- 描述清晰度
- 需要澄清
- 新手友好度
- 35/100