patternfly / patternfly/patternfly-react
Bug - Table - several variants don't allow customizing aria labeling
Personne n'a encore pris cette issue.
- Langage dominant
- TypeScript
- Étoiles
- 862
- Forks
- 392
- Merge moyen
- 4 j 8 h
- PR mergées (30 j)
- 9
Description
[Edited by @thatblindgeye 11/7/2025]
This issue should involve fixing the following (we should try to prioritize the first 2 items, as they are affecting the new Compass demos):
-
The action buttons in the ActionsColumn should allow customizing the aria-label and aria-labelledby on MenuToggle, rather than hardcoding them as "Kebab toggle"
-
For selectable with checkbox/radio, we need to allow customizing the aria-label and aria-labelledby for the inputs, and also update the default values to be
index + 1(currently the first row will read "Select row 0", which makes sense from an index persepective but from a user perspective it should probably be "Select row 1") -
The Table sort functionality should allow passing some SR text to help identify what order the column is sorted.
- If we have any implementations where a sort button is standalone without any text, we should allow passing an aria-label and aria-labelledby to those as well
-
The Favorite button in FavoritesCell should allow customizing the aria-label and aria-labelledby (props are being spread in this file, but would need to check if how it's actually used with decorators if it's possible to override the default hardcoded values and pass in aria-labelledby)
-
DraggableCell default value should omit the word "button" in its default aria-label at the very least. Ideally we either wouldn't have a default value or the default would be able to be more unique as its used (right now every row will default to the same exact label which isn't good)
- We should also check if it's actually possible to override the default labels, and add the ability to use aria-labelledby
After these are completed, we want to open followup issues/PRs in Org to update any new Compass demos using a Table with any of the above functionality
[Original ticket below]
Describe the problem
It's not possible to add aria-label in Table sorts, so I can't use semantic syntax. If I'm a user who needs a screen reader to sort some data by name, for example, I just listen "name button" and not something with a better description.
Expected behavior
If I'm a user who needs a screen reader, when clicking in a button I should listen to a descriptive message about the functionality of the button, for accessibility purpose. So, when I have data inside a Table and I want to sort that data, I need to listen to a clear message.
Is this issue blocking you?
No
What is your environment?
- RHEL 8.6
- Browser Chrome
What is your product and what release date are you targeting?
consoledot
Jira Issue: PF-136
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par le composant Table et ses variantes ActionsColumn, selectable checkbox/radio inputs, sort controls, FavoritesCell et DraggableCell mentionnées dans l’issue. Examinez la manière dont leurs aria labels actuels sont définis et vérifiez chaque exigence de personnalisation et de valeur par défaut listée, y compris les cas sort et standalone-button. Le travail est terminé lorsque les variantes de Table concernées prennent en charge le libellé accessible demandé et sont prêtes pour les mises à jour ultérieures de la démo Compass.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- react, typescript
- Domaine
- accessibility, frontend
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100