patternfly / patternfly/patternfly-react
Bug - [Masthead] - MastheadBrand icons is reloaded
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Every time the Dropdown component is toggled, the MastheadBrand/MastheadBrand Image component is reloaded. This issue only occurs when using MastheadBrand with an icon router link. The affected components are Dropdown and MastheadBrand/MastheadBrand Image.
How do you reproduce the problem?
Use MastheadBrand with an icon router link.
Toggle the Dropdown component.
Notice that the MastheadBrand/MastheadBrand Image component is reloaded each time the Dropdown state changes.
Expected behavior
The MastheadBrand/MastheadBrand Image component should not be reloaded when toggling the Dropdown component, regardless of whether MastheadBrand is used with an icon router link or not.
Is this issue blocking you?
This issue may not be critical, but it can affect the performance of the website/application. A workaround could be to use MastheadBrand without an icon router link.
Code Sandbox:
https://26rvq2.csb.app/
Open and close the menu bar on the right, and observe the logo. The issue is observed in specific versions of browsers only.
Screenshots
N/A
What is your environment?
OS: MacOS 13.2
Browser: Version 111.0.5563.64 (Official Build) (x86_64)
Version: ^4.276.6
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Dropdown 和 MastheadBrand/MastheadBrand Image 组件开始,使用链接的 CodeSandbox 重现该行为。使用配置了 icon router link 的 MastheadBrand 切换菜单,然后将其与没有该配置的版本进行比较。当 Dropdown 状态变化时,MastheadBrand 或 MastheadBrand Image 组件不再重新加载,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- frontend
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100