patternfly / patternfly/patternfly-react
Page - change notificationDrawer props to be more generic
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
re: https://github.com/patternfly/patternfly-react/issues/8541#issuecomment-1384624420
There are currently a props on the <Page> component (notificationDrawer and isNotificationDrawerExpanded) that attach a drawer to the page. AFAIK there is no requirement to use a notification drawer there - the props just update the page to support a drawer that appears over the main content area. Assuming we don't want to limit that use of a drawer in the page to notification drawer only, I wonder if it makes sense to rename those props to something more generic so it's clear it can be used for any sort of drawer content.
cc @mcarrano @mceledonia @tlabaj
Jira Issue: PF-141
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Page component and search for the notificationDrawer and isNotificationDrawerExpanded props and their usages. Confirm the generic naming expected for drawer content, update the affected references, and verify that the Page drawer behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100