patternfly / patternfly/patternfly-react
Chore(docs): Add composable structure section and component descriptions to documentation
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- TypeScript
- Estrellas
- 862
- Forks
- 392
- Merge medio
- 4 d 8 h
- PR fusionados (30 d)
- 9
Descripción
Describe the issue. What is the expected and unexpected behavior?
Consider adding a "General intended structure" section to documentation for more compassable components, and add descriptions for sub-components in the "Props" section to provide more details on their use-cases.
For sub-component descriptions, we should consider ensuring that any sub-components used in examples/exported for consumer use are added to the "Props" section. For example, Application Launcher has examples using ApplicationLauncherSeparator, but that is not included in the props section of the component page. Note: this will cause an issue for sub-components that do not export a props interface, as an empty table will be rendered to that section of the component page.
Additionally, we should align on when to include other components on a page's "Props" section. The Login Page component, for example, uses List and ListItem in some examples, but does not include the props table for them. The Alert Group component on the other hand includes the Alert props table.
e.g.
General intended structure
File upload - multiple is designed in a composable manner to maximize flexibility. The general intended component relationships are arranged similarly to:
See #7603 for working examples
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
enhancement
Needs only sub-component descriptions:
-
#7973
-
#7978
-
#8105
-
Wizard
Needs both "composable structure" and sub-component descriptions:
-
Accordion
-
Action list
-
Alert group (currently the alert group page includes Alert specific components in the "Props" section)
-
Application launcher (partially composable)
-
Breadcrumb
-
Card
-
Clipboard copy (currently the component page includes ClipboardCopyButton in the "Props" section, but the component isn't used in any examples. If we want to keep this, it may be worth considering whether any other sub-components should be exposed on all components)
-
Chip group (currently the chip group page includes the Chip component in the "Props" section)
-
Code block
-
Context selector
-
Data list
-
Description list
-
Drag and drop (wait for Nicole to provide feedback)
-
Drawer
-
Dropdown (partially composable)
-
#7692
-
Empty state
-
Form
-
Form select
-
Helper text
-
Hint
-
Input group
-
Jump links
-
Label group (currently the label group page includes the Label component in its "Props" section)
-
List
-
Login page
-
Masthead
-
Menu
-
#7691
-
Navigation
-
Notification drawer
-
Options menu (partially composable)
-
Overflow menu
-
Page
-
Panel
-
Progress stepper
-
Select (partially composable)
-
Sidebar
-
Simple list
-
Table Composable (because of the different variants of a table, the structure section may need to be split up to several different ones)
-
Table Legacy (could arguably only require sub-component descriptions, but since examples show the
TableHeaderinside ofTableit might be good to include some sort of "intended structure" section/mention) -
Tabs
-
Text
-
Text input group
-
Toggle group
-
Toolbar
Jira Issue: PF-187
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con las páginas de documentación de componentes indicadas en la issue y revisa los ejemplos, las secciones Props existentes y los ejemplos funcionales de #7603. Acuerda qué subcomponentes deben pertenecer a Props y qué páginas necesitan una sección general sobre la estructura prevista; después, actualiza las páginas de componentes no marcadas y verifica que los ejemplos y las descripciones estén documentados de forma coherente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- react, typescript
- Área
- documentation
- Tipo de issue
- Documentación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 30/100