patternfly / patternfly/patternfly-react
error when using npm to run install
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
when using npm 8 to execute npm install I get the following error:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: eslint-plugin-patternfly-react@4.23.2
npm ERR! Found: eslint@8.7.0
npm ERR! node_modules/eslint
npm ERR! peer eslint@">=5" from eslint-plugin-patternfly-react@4.23.2
npm ERR! packages/eslint-plugin-patternfly-react
npm ERR! eslint-plugin-patternfly-react@4.23.2
npm ERR! node_modules/eslint-plugin-patternfly-react
npm ERR! workspace packages/eslint-plugin-patternfly-react from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^4.9.0" from eslint-config-airbnb@16.1.0
npm ERR! node_modules/eslint-config-airbnb
npm ERR! eslint-config-airbnb@"^16.1.0" from eslint-plugin-patternfly-react@4.23.2
npm ERR! packages/eslint-plugin-patternfly-react
npm ERR! eslint-plugin-patternfly-react@4.23.2
npm ERR! node_modules/eslint-plugin-patternfly-react
npm ERR! workspace packages/eslint-plugin-patternfly-react from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/nthoen/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/nthoen/.npm/_logs/2022-01-17T13_07_09_970Z-debug-0.log
It seems - according to stack overflow that "When using npm 7, this comes up a lot because peer dependencies issues are treated as errors in version 7 whereas they were generally only warnings in version 6. Usually using --legacy-peer-deps makes it work with npm 7[+].”
When I run npm install --legacy-peer-deps, the install works with no errors.
It seems we might need to either readdress our dependencies, or update our README to suggest adding the flag or opting for yarn to perform the install
Jira Issue: PF-190
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先检查仓库中针对 eslint-plugin-patternfly-react 和 eslint-config-airbnb 的依赖声明,然后使用 npm install 在 npm 8 中重现失败。检查 README 中的安装说明,确认其中关于受支持包管理器的指导。完成的标准是:标准安装无需不正确的 peer-dependency workaround 即可正常工作,或者所需的 flag 或替代包管理器已被记录在文档中。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- eslint, typescript
- 领域
- build-system, tooling
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100