patternfly / patternfly/patternfly-react
error when using npm to run install
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
when using npm 8 to execute npm install I get the following error:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: eslint-plugin-patternfly-react@4.23.2
npm ERR! Found: eslint@8.7.0
npm ERR! node_modules/eslint
npm ERR! peer eslint@">=5" from eslint-plugin-patternfly-react@4.23.2
npm ERR! packages/eslint-plugin-patternfly-react
npm ERR! eslint-plugin-patternfly-react@4.23.2
npm ERR! node_modules/eslint-plugin-patternfly-react
npm ERR! workspace packages/eslint-plugin-patternfly-react from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^4.9.0" from eslint-config-airbnb@16.1.0
npm ERR! node_modules/eslint-config-airbnb
npm ERR! eslint-config-airbnb@"^16.1.0" from eslint-plugin-patternfly-react@4.23.2
npm ERR! packages/eslint-plugin-patternfly-react
npm ERR! eslint-plugin-patternfly-react@4.23.2
npm ERR! node_modules/eslint-plugin-patternfly-react
npm ERR! workspace packages/eslint-plugin-patternfly-react from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/nthoen/.npm/eresolve-report.txt for a full report.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/nthoen/.npm/_logs/2022-01-17T13_07_09_970Z-debug-0.log
It seems - according to stack overflow that "When using npm 7, this comes up a lot because peer dependencies issues are treated as errors in version 7 whereas they were generally only warnings in version 6. Usually using --legacy-peer-deps makes it work with npm 7[+].”
When I run npm install --legacy-peer-deps, the install works with no errors.
It seems we might need to either readdress our dependencies, or update our README to suggest adding the flag or opting for yarn to perform the install
Jira Issue: PF-190
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the repository's dependency declarations for eslint-plugin-patternfly-react and eslint-config-airbnb, then reproduce the failure with npm 8 using npm install. Check the README's installation instructions for the supported package-manager guidance. Done means a standard install works without an incorrect peer-dependency workaround, or the required flag or alternative package manager is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- eslint, typescript
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100