patternfly / patternfly/patternfly-react
Page: tabIndex default value (mainTabIndex=-1) which prevents keyboard scroll
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the issue. What is the expected and unexpected behavior?
mainTabIndex=-1 as a default value prevents keyboard scroll. tlabindex should be removed. Having a tabindex on a container essentially breaks focus and keyboard scroll for all non-focusable containers below it. eg topology details side panel.
Any contributions to the main content should not have to deal with adding their own tabindex attribute to their scroll containers.
Above notes from the pr: https://github.com/openshift/console/pull/9140#issuecomment-854134911
workaround is to set the mainTabIndex to null.
Please provide the steps to reproduce. Feel free to link CodeSandbox or another tool.
https://github.com/openshift/console/pull/9140#issuecomment-8541349113
Is this a bug or enhancement? If this issue is a bug, is this issue blocking you or is there a work-around?
Bug
What is your product and what release version are you targeting?
OpenShift 4.9
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从所引用的 PatternFly React pull request #9140 及其链接的 issue comment 入手,找到 mainTabIndex 的默认值。移除默认的 tabindex 行为,然后验证不可聚焦容器无需 mainTabIndex workaround 即可使用键盘滚动。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility, frontend
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100