patternfly / patternfly/patternfly-react
Bug - RTL demo cleanup
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Noticed this page could use some updates https://www.patternfly.org/patterns/right-to-left/react-demos/paginated-table/
-
Remove the card wrapping the page content
-
Update probably all of the
<Icon />components to use the inline variant so they inherit the icon color from their parent. You can see the problem when switching to dark theme -
On mobile the masthead menu goes off screen as seen in Exhibit A
-
The logo shifts away from the hamburger menu in RTL as seen in Exhibit B
References
Exhibit A
Exhibit B
Jira Issue: PF-3991
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the RTL paginated-table React demo at the linked PatternFly page and inspect its card wrapper, Icon components, masthead menu, and logo layout. Done means the card is removed, icons inherit their parent color in dark theme, and the masthead and logo remain correctly positioned on mobile in RTL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100