patternfly / patternfly/patternfly-react
Button - secondary color
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Is this a new component or an extension?
Enhancement to a current feature
Existing Component
Button
Describe the feature
Right now secondary color exists but is always mapped to the primary color for example button has a secondary type but the color is the same.
Also it seems that secondary is not the same as primary for dark theme.
There is a variable called --pf-v5-global--secondary-color why not use it for things that have a secondary type?
@patternfly-v5/patternfly/components/Button/button.css: --pf-v5-c-button--m-secondary--Color: var(--pf-v5-global--primary-color--100);
User Story
As a user I would like to have secondary buttons to have a different color as primary a one... (which is only possible in dark theme, but not in light)
Visuals & Mockups
No response
Interaction States & Variations
idk
Accessibility (A11y)
No response
Product & Target Release
No response
Contribution
-
I am interested in contributing this feature.
-
I have searched for similar existing requests.
Jira Issue: PF-3513
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 @patternfly-v5/patternfly/components/Button/button.css 开始,检查 secondary button 的颜色变量,以及 primary 和全局 secondary 颜色定义。确认 secondary button 使用预期的 secondary 颜色,并且在浅色和深色主题中都与 primary button 保持区别。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- css, react
- 领域
- design, frontend
- Issue 类型
- 功能
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 62/100