patternfly / patternfly/patternfly-react
Bug - Popover/Modal - Modals and popover do not render properly when Fullscreen API is used
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the problem
A clear and concise description of the problem. Which components are affected?
When the fullscreen API is used, the browser does not render the entire document tree. Popovers and modals, which append to document.body by default might not be included in the scope of the fullscreen element.
How do you reproduce the problem?
Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.
adapted from https://www.patternfly.org/components/modal#basic-modals:
import * as React from 'react';
import { Button, Modal, ModalBody, ModalFooter, ModalHeader } from '@patternfly/react-core';
export const useFullscreen = () => {
/_* The element that will be toggled to fullscreen _/
const fullscreenRef = React.useRef(null);
/_* Toggle currently displayed content to/from fullscreen _/
const toggleFullscreen = React.useCallback(() => {
if (fullscreenRef.current) {
if (!document.fullscreenElement) {
fullscreenRef.current.requestFullscreen();
} else {
document.exitFullscreen();
}
}
}, []);
return [fullscreenRef, toggleFullscreen];
};
export const ModalBasic: React.FunctionComponent = () => {
const [isModalOpen, setIsModalOpen] = React.useState(false);
const [fullscreenRef, toggleFullscreen] = useFullscreen();
const handleModalToggle = (_event: KeyboardEvent | React.MouseEvent) => {
setIsModalOpen(!isModalOpen);
};
return (
[div ref={fullscreenRef}]
[Button onClick={toggleFullscreen}]toggle fullscreen[/Button]
[Button variant="primary" onClick={handleModalToggle} ouiaId="ShowBasicModal"]
Show basic modal
[/Button]
[Modal
isOpen={isModalOpen}
onClose={handleModalToggle}
ouiaId="BasicModal"
aria-labelledby="basic-modal-title"
aria-describedby="modal-box-body-basic"
]
[ModalHeader title="Basic modal" labelId="basic-modal-title" /]
[ModalBody id="modal-box-body-basic"]
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore
magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id
est laborum.
[/ModalBody]
[ModalFooter]
[Button key="confirm" variant="primary" onClick={handleModalToggle}]
Confirm
[/Button]
[Button key="cancel" variant="link" onClick={handleModalToggle}]
Cancel
[/Button]
[/ModalFooter]
[/Modal]
[/div]
);
};
Expected behavior
A clear and concise description of the expected behavior.
The modal appends to the fullscreenElement when the browser is fullscreen
Is this issue blocking you?
List the workaround if there is one.
Sort of..? This is causing issues in #15254 and my workaround is to simply disable any elements that generate popovers when the browser is fullscreened
Screenshots
If applicable, add screenshots to help explain the issue.
What is your environment?
Firefox 140.0-1.fc42
What is your product and what release date are you targeting?
OCP console 4.20
Any other information?
We can update the default value of appendTo to be () => document.fullscreenElement ?? document.body which will probably fix this. We will need to update the value of appendTo dynamically when the user exit and enters fullscreen however
Jira Issue: PF-2357
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
先从 Modal 和 popover 的 appendTo 处理开始,然后在进入和退出全屏时复现提供的 CodeSandbox。验证在全屏期间 modal 是否渲染在 document.fullscreenElement 内,并在之后返回 document.body,包括两个方向的转换。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- frontend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 54/100