patternfly / patternfly/patternfly-react
Button - update console error for accessible name and move aria-expanded location
未关闭
还没有人认领这个 Issue。
Breaking change :boom:
PF Team
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Describe the enhancement or change
Followup to some comments left in https://github.com/patternfly/patternfly-react/pull/11861/
- The console error with the
isSettings || isHamburger || isFavoriteconditional for the accessible name (line 164 in that PR) should be updated to remove that conditional. We should be throwing an error for any button that doesn't have children, aria-label, or aria-labelledby - The
aria-expandedattribute (line 239) should be moved below the{...props}so that it won't be overridden by a manualaria-expandedbeing passed in - Several tests related to the above points will need to be updated in some fashion as well
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
Any other information?
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先查看 pull request #11861 中引用的更改,尤其是第 164 行附近的 accessible-name 控制台错误以及第 239 行附近的 aria-expanded 处理。找到 issue 中提到的相关 Button 测试,根据要求的行为更新这些测试,并确认错误和属性处理符合所述要求。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- accessibility, frontend
- Issue 类型
- 功能
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 55/100