patternfly / patternfly/patternfly-react

Button - update console error for accessible name and move aria-expanded location

Open
#11,871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking change :boom: PF Team
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the enhancement or change
Followup to some comments left in https://github.com/patternfly/patternfly-react/pull/11861/

  • The console error with the isSettings || isHamburger || isFavorite conditional for the accessible name (line 164 in that PR) should be updated to remove that conditional. We should be throwing an error for any button that doesn't have children, aria-label, or aria-labelledby
  • The aria-expanded attribute (line 239) should be moved below the {...props} so that it won't be overridden by a manual aria-expanded being passed in
  • Several tests related to the above points will need to be updated in some fashion as well

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced changes in pull request #11861, especially the accessible-name console error around line 164 and the aria-expanded handling around line 239. Locate the related Button tests mentioned in the issue, update them for the requested behavior, and confirm the error and attribute handling match the stated requirements.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.