patternfly / patternfly/patternfly-react

DualListSelector/TreeView/Form - remove opt-in animation logic

Open
#11,838 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking change :boom: PF Team
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the enhancement or change
In the next breaking change release, we need to remove the opt-in logic for animations in these components so that animations are on by default. This will include at least removing any hasAnimations prop as well as ensuring any children are rendered always (rather than only when a parent item isExpanded).

Applicable PRs:

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the applicable PRs 11843, 11837, and 11842, then inspect the DualListSelector, TreeView, and Form components they address. The change is done when opt-in animation logic, including hasAnimations handling, is removed and children render regardless of a parent item's isExpanded state.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.